Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability updates for lua bench testing #253

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

maurermi
Copy link
Collaborator

Add in script for running lua bench, and add
configurable logging to the lua bench test.

Also updates .gitignore to ignore installed
lua files but not files in a 'lua/' subdirectory.

This lua bench script is a more fleshed out version
of the one added in PR #241

Add in script for running lua bench, and add
configurable logging to the lua bench test.

Also updates .gitignore to ignore installed
lua files but not files in a 'lua/' subdirectory.

Signed-off-by: Michael Maurer <[email protected]>
@HalosGhost
Copy link
Collaborator

utACK; looks like a straightforward addition of a wrapper benchmarking script for the lua runner along with a touch more logging and an update to the ignore file. Do you have a suggested procedure for a tACK?

@maurermi
Copy link
Collaborator Author

@HalosGhost This is indeed a very small change, to test I would suggest is to run parsec locally, and then run the Lua bench script (potentially as follows):

(configure, build, etc...)
./scripts/parsec-run-local.sh --runner_type=lua --port=8889
(wait for spawn ...)
./scripts/lua_bench.sh --loglevel=TRACE

I assert that this should work and run the Lua bench test locally with trace logging

Copy link
Collaborator

@HalosGhost HalosGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Builds, all tests pass, and the procedure above successfully runs a lua-runner benchmark, producing a tx-sample output.

Looks like a really pleasant QoL improvement to me. Merging!

@HalosGhost HalosGhost merged commit f805c64 into mit-dci:trunk Apr 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants