Skip to content

Add some Certificate Authorities to trust store for AssetFetcher#4009

Open
jisqyv wants to merge 1 commit into
mit-cml:ucrfrom
jisqyv:trusting-companion
Open

Add some Certificate Authorities to trust store for AssetFetcher#4009
jisqyv wants to merge 1 commit into
mit-cml:ucrfrom
jisqyv:trusting-companion

Conversation

@jisqyv

@jisqyv jisqyv commented Jun 23, 2026

Copy link
Copy Markdown
Member

Older versions of Android do not trust the Let's Encrypt Root. So we add it to the TrustManager for the connection we use in the AssetFetcher.

This code was cribded from ChatBot.java and put into its own class. At some point we should refactor ChatBot, Imagebot and CloudDB to use this new class.

Change-Id: Ifcc680295782b7aa6d04781c3230d026ae7af344

What does this PR accomplish?
Permits older devices to use sites protected by Let's Encrypt, whose root certificate is not in the trust store of older devices
Description

Testing Guidelines

Fixes # .

Resolves # .

Context for the changes

If this PR changes anything related to the companion make sure you have used the ucr branch. For all other changes use master or provide context for having used a different branch.
See a summary of git branches in the docs: App Inventor Developer Overview

If your code changes how something works on the device (i.e., it affects the companion):

  • I have made no changes that affect the companion

  • I branched from ucr

  • My pull request has ucr as the base

Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):

  • I have updated the corresponding version number in appinventor/components/src/.../common/YaVersion.java
  • I have updated the corresponding upgrader in appinventor/appengine/src/.../client/youngandroid/YoungAndroidFormUpgrader.java (components only)
  • I have updated the corresponding entries in appinventor/blocklyeditor/src/versioning.js

For all other changes:

  • I have made no changes that affect the master branch

  • I branched from master

  • My pull request has master as the base

General items:

  • I have updated the relevant documentation files under docs/
  • My code follows the:
  • ant tests passes on my machine

Older versions of Android do not trust the Let's Encrypt Root. So we
add it to the TrustManager for the connection we use in the
AssetFetcher.

This code was cribded from ChatBot.java and put into its own class. At
some point we should refactor ChatBot, Imagebot and CloudDB to use
this new class.

Change-Id: Ifcc680295782b7aa6d04781c3230d026ae7af344
@jisqyv jisqyv requested a review from a team June 23, 2026 16:50
@jisqyv jisqyv added this to the nb205 milestone Jun 23, 2026
@jisqyv jisqyv added for-ai2-test on ai2-test Code is deployed on ai2-test.appinventor.mit.edu labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

affects: ucr for-ai2-test on ai2-test Code is deployed on ai2-test.appinventor.mit.edu pull request: needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant