Add some Certificate Authorities to trust store for AssetFetcher#4009
Open
jisqyv wants to merge 1 commit into
Open
Add some Certificate Authorities to trust store for AssetFetcher#4009jisqyv wants to merge 1 commit into
jisqyv wants to merge 1 commit into
Conversation
Older versions of Android do not trust the Let's Encrypt Root. So we add it to the TrustManager for the connection we use in the AssetFetcher. This code was cribded from ChatBot.java and put into its own class. At some point we should refactor ChatBot, Imagebot and CloudDB to use this new class. Change-Id: Ifcc680295782b7aa6d04781c3230d026ae7af344
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older versions of Android do not trust the Let's Encrypt Root. So we add it to the TrustManager for the connection we use in the AssetFetcher.
This code was cribded from ChatBot.java and put into its own class. At some point we should refactor ChatBot, Imagebot and CloudDB to use this new class.
Change-Id: Ifcc680295782b7aa6d04781c3230d026ae7af344
What does this PR accomplish?
Permits older devices to use sites protected by Let's Encrypt, whose root certificate is not in the trust store of older devices
Description
Testing Guidelines
Fixes # .
Resolves # .
Context for the changes
If this PR changes anything related to the companion make sure you have used the
ucrbranch. For all other changes usemasteror provide context for having used a different branch.See a summary of git branches in the docs: App Inventor Developer Overview
If your code changes how something works on the device (i.e., it affects the companion):
I have made no changes that affect the companion
I branched from
ucrMy pull request has
ucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
I have made no changes that affect the master branch
I branched from
masterMy pull request has
masteras the baseGeneral items:
ant testspasses on my machine