Add Typescript support for afterCreate #1054
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #1052. Includes a test in
factory-test.ts
.By the way, in that test file,
// $ExpectError
still shows as a TS error, although that might just be for me in Webstorm.// @ts-expect-error
, placed above the line, shows no red wavy line. Although I don't know if there's a similar equivalent for$ExpectType
. @zoltan-nz is there anywhere that these "tests" are run or anything?I would be happy to swap those error assertions as part of this PR, or alternatively in a separate PR, if you'd like. Let me know!
(馃コ my first OSS PR!)