fix: header navigation current link styles #755
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With 'latest Manon' you mean v16.2 right? |
Good one. I have updated the PR with the corresponding versions. |
ppvg
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with theme v0.1.0-beta.2 and manon v17.0.0-beta.1 the current link looks like:
The
Flowitem should look active.Chrome Dev tools is showing that the current-link-focus variables are missing, but these variables should not be needed for only the current link styling.
Current link styling should come from here:
nl-rdo-manon/manon/header-navigation-link-active.scss
Lines 24 to 27 in fa0ae27
Instead from, so I removed the
@extendline.nl-rdo-manon/manon/header-navigation-link-focus.scss
Lines 30 to 33 in fa0ae27
Also the current link focus variables are still missing, so I default them to the focus variables.
After these changes the active item looks good.