heal: Dangling check to evaluate object parts separately #19797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harshavardhana @klauspost can you please take a look at this ? there is a lot of tests that need to be fixed and I prefer if I do that after we agree about the changes here |
|
The approach itself is fine @vadmeste |
|
Since this change will take time, I will add the commit that would take out dataErrs completely for now. |
harshavardhana
added a commit
that referenced
this pull request
May 25, 2024
avoid this until a comprehensive change is merged such as #19797
vadmeste
force-pushed
the
fix-dangling-corner-case
branch
from
e365223
to
637c568
Compare
klauspost
reviewed
May 28, 2024
vadmeste
force-pushed
the
fix-dangling-corner-case
branch
6 times, most recently
from
cc36e2e
to
8692a80
Compare
harshavardhana
approved these changes
Jun 6, 2024
vadmeste
force-pushed
the
fix-dangling-corner-case
branch
from
8692a80
to
3302d1b
Compare
klauspost
reviewed
Jun 7, 2024
vadmeste
force-pushed
the
fix-dangling-corner-case
branch
from
3302d1b
to
77d9679
Compare
I did it for him 🍰 |
|
yes, tests are passing now, PTAL @klauspost |
klauspost
approved these changes
Jun 10, 2024
yeah big time, such an old historic issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)