Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate drive health related metrics into single metric #19706

Merged
merged 3 commits into from
May 12, 2024

Conversation

anjalshireesh
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Instead of having "online" and "healing" as two metrics, replace with a single metric "health" which can have following values:

0 = offline
1 = healthy
2 = healing

Motivation and Context

better metrics

How to test this PR?

curl "http://<endpoint>/minio/metrics/v3/system/drive"

should return a new metric minio_system_drive_health in place of the two erstwhile metrics minio_system_drive_online and minio_system_drive_healing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

Instead of having "online" and "healing" as two metrics, replace with a
single metric "health" which can have following values:

0 = offline
1 = healthy
2 = healing
@anjalshireesh anjalshireesh marked this pull request as ready for review May 9, 2024 14:13
Copy link
Member

@donatello donatello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using an "enum" here doesn't seem very understandable. If this metric is graphed, it seems more complicated to understand - why do we need to do this? At the very least, it seems better to let the numbers indicate health value (higher => more healthy in a sense):
0 -> offline
1 -> healing
2 -> healthy

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 074d701 into minio:master May 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants