Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show storage on the about page #3191

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

stenius
Copy link
Contributor

@stenius stenius commented Mar 4, 2025

feat: This PR adds database usage information to the about page.

It is written to address #3190

Screenshot from 2025-03-04 18-46-41


Have you followed these guidelines?

Copy link
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more appropriate to check the Postgres database size rather than the local disk usage, as some people may run the application and database on separate machines.

@stenius
Copy link
Contributor Author

stenius commented Mar 4, 2025

It would be more appropriate to check the Postgres database size rather than the local disk usage, as some people may run the application and database on separate machines.

Thanks for getting back to me @fguillot. I'll try to take a crack at it later tonight after work.

My plan is to use the current postgres database, or use the database specified by the database_url, and use pg_database_size(name) to display only the usage.

In the future, a new ENV could be introduced MAX_DATABASE_SIZE which could be used to set limits on the amount of articles saved.

@stenius
Copy link
Contributor Author

stenius commented Mar 4, 2025

@fguillot, Alright, I've got it updated so it's now displaying the DBSize on the about page. Do I need to create translations for all the languages?

@stenius stenius requested a review from fguillot March 4, 2025 23:43
@stenius
Copy link
Contributor Author

stenius commented Mar 5, 2025

@fguillot I've opened up another PR which contains a make command to make localizing new strings easier. #3196

@stenius
Copy link
Contributor Author

stenius commented Mar 5, 2025

@fguillot You speak French right? Would you mind adding the French translation please?

@stenius stenius marked this pull request as ready for review March 5, 2025 00:33
Copy link
Contributor Author

@stenius stenius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's going to be a bit of shuffling here since things weren't alphabetized.

@stenius stenius requested a review from fguillot March 5, 2025 14:02
@fguillot fguillot linked an issue Mar 5, 2025 that may be closed by this pull request
1 task
@fguillot fguillot merged commit 0cf5051 into miniflux:main Mar 5, 2025
9 checks passed
@stenius stenius deleted the ps_show_storage branch March 6, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Show storage usage on About page.
2 participants