-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix incorrect on-premise refs from PR #1023 #1097
base: master
Are you sure you want to change the base?
docs: Fix incorrect on-premise refs from PR #1023 #1097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Revert changes in the CHANGELOG.md file as the changes are related to what changed in the version 0.16.
@alexmalins Can you check the changes asked in the review when you will have time. |
hey @gabriel-tessier ! thanks for the review
Are you sure this is the right thing to do? 0.16.0 made the breaking change 0.24.0 (incorrectly documented as 0.23.5 in the changelog) made the second breaking change from #1023 of A wider issue is the changelog hasn't been well maintained since the v0.17.0 release. None of the subsequent releases are documented in the change log, other than @filipeaaoliveira 's work in #1023 - which was put in at the bottom of the changelog instead of at the more usual top position. If you like I could add another commit to bring the changelog up to date, by back filling the changes since v0.17.0 and reordering everything correctly? |
Yep sorry, as you noticed the file is no more used and when I asked filipeaaoliveira to add the changelog in the PR review I forget that mingrammer were no more using the file. Sorry for the confusion, so to sum things up:
After that I will just wait for another maintainer to review and your changes will be merged in master. |
import of which broken the image links on the Examples page for the AWS on-premises examples This PR corrects the issues and uses on-premises where needed
a54a3cc
to
ff174e3
Compare
Understood thanks @gabriel-tessier ! |
#1023 had a small number of mistakes, the most import of which broke the image links on the Examples page for the AWS on-premises examples
This PR corrects the issues and uses on-premises (or one instance of on-premise in the changelog) where needed