Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 계좌 등록 API 추가 #85

Merged
merged 1 commit into from
Feb 24, 2024
Merged

✨ 계좌 등록 API 추가 #85

merged 1 commit into from
Feb 24, 2024

Conversation

mingi3314
Copy link
Owner

@mingi3314 mingi3314 commented Feb 24, 2024


Generated summary (powered by Graphite)

TL;DR

This pull request introduces the ability to create new accounts via the API. It includes the addition of new request and response models for account creation, as well as the necessary changes to the account service and account model.

What changed

  • Added AccountCreateRequest and AccountCreateResponse models to handle account creation requests and responses.
  • Added a new POST endpoint /accounts to create a new account.
  • Added an id field to the Account model, which is automatically generated using uuid.uuid4.

How to test

  1. Pull the changes from this branch into your local environment.
  2. Run the application.
  3. Use a tool like curl or Postman to send a POST request to /accounts with the necessary data (brokerage, app_key, secret_key).
  4. Verify that the response includes the newly created account's ID and that the account is correctly created.

Why make this change

This change allows users to create new accounts via the API, which is a necessary feature for any trading application. It also introduces a unique ID for each account, which can be used to identify and manage accounts.

Copy link
Owner Author

mingi3314 commented Feb 24, 2024

Merge activity

@mingi3314 mingi3314 merged commit 7ed3ef9 into main Feb 24, 2024
2 checks passed
@mingi3314 mingi3314 deleted the 02-24-_API_ branch February 24, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant