Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some basic refactoring and improvements #5

Open
wants to merge 1 commit into
base: dev1
Choose a base branch
from
Open

Some basic refactoring and improvements #5

wants to merge 1 commit into from

Conversation

fentonscode
Copy link
Contributor

Some quick changes as below:

  • PEP formatting and static checks
  • Type hints
  • Redundant or improper comparisons
  • Redundant deepcopy call (carefully checked, there's a few mode to remove)
  • Some faster pure Python code in places
  • Some major speedups in the jit functions (still a few to go in the Matern code too)

fentonscode
fentonscode commented Oct 14, 2021
View reviewed changes
dgpsi/functions.py
K2=np.zeros((n,n))
if name == 'sexp':
X_l = X / length
# ~50% faster by avoiding expand_dims
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have said "100%", same effect below in the other jit functions

@mingdeyu mingdeyu changed the base branch from master to dev1 October 16, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fentonscode