Skip to content

[datasets] feat: add croatian vocabulary #1923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025

Conversation

cyanic-selkie
Copy link
Contributor

@cyanic-selkie cyanic-selkie commented Apr 20, 2025

I have two questions:

  1. How do you want to handle languages that use a dual writing system (e.g., Serbian)? Do you want to be able to address them individually so they can be blacklisted/whitelisted or just put them in the same bucket?
  2. Can I contribute wordlists? I don't know how you're generating them at the moment.

@felixdittrich92 felixdittrich92 added this to the 0.12.0 milestone Apr 21, 2025
@felixdittrich92 felixdittrich92 added topic: documentation Improvements or additions to documentation type: enhancement Improvement module: datasets Related to doctr.datasets ext: docs Related to docs folder labels Apr 21, 2025
@felixdittrich92 felixdittrich92 self-assigned this Apr 21, 2025
Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (579869b) to head (0eaaf80).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1923   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files         172      172           
  Lines        8441     8442    +1     
=======================================
+ Hits         8170     8171    +1     
  Misses        271      271           
Flag Coverage Δ
unittests 96.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@felixdittrich92 felixdittrich92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cyanic-selkie 👍

  1. Correct in this case it would be serbian_latin and serbian_cyrillic 👍
  2. I will create a HF space which provides a way to upload resources like workdlists and fonts - because I would like to avoid adding such resource files to the repo directly

@felixdittrich92 felixdittrich92 changed the title feat: add croatian vocabulary [datasets] feat: add croatian vocabulary Apr 21, 2025
@felixdittrich92 felixdittrich92 merged commit 903e911 into mindee:main Apr 21, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: docs Related to docs folder module: datasets Related to doctr.datasets topic: documentation Improvements or additions to documentation type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants