Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[models] Change default model to fast_base - soft breaking change #1588

Merged
merged 1 commit into from May 15, 2024

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented May 7, 2024

This PR:

  • changes the default detection model from db_resnet50 to fast_base
  • reason:
    • more accure (actually much much better also on rotated samples) / needs less memory / small bit faster

Any feedback is welcome 🤗

NOTE: marked as breaking change because with the next release we should mention this change and to revert to the previous behavior that it only requires to pass db_resnet50 as det_arch

@felixdittrich92 felixdittrich92 added type: enhancement Improvement module: models Related to doctr.models ext: tests Related to tests folder type: breaking change Introducing a breaking change ext: demo Related to demo folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend topic: text detection Related to the task of text detection labels May 7, 2024
@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone May 7, 2024
@felixdittrich92 felixdittrich92 self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (bf82d63) to head (ef294f1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
+ Coverage   96.33%   96.35%   +0.01%     
==========================================
  Files         163      163              
  Lines        7702     7702              
==========================================
+ Hits         7420     7421       +1     
+ Misses        282      281       -1     
Flag Coverage Δ
unittests 96.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@odulcy-mindee odulcy-mindee merged commit 3f116ad into mindee:main May 15, 2024
74 of 81 checks passed
@felixdittrich92 felixdittrich92 deleted the default-model branch May 15, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: demo Related to demo folder ext: tests Related to tests folder framework: pytorch Related to PyTorch backend framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models topic: text detection Related to the task of text detection type: breaking change Introducing a breaking change type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants