Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] page orientation improvements #1553

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

felixdittrich92
Copy link
Contributor

@felixdittrich92 felixdittrich92 commented Apr 15, 2024

This PR:

  • refactor OCRPredictor logic (limit duplication)
  • extend estimate angle function to handle also upside-down images
  • correct return value from estimate angle (negative - left side rot / positive - right side rot) -> update tests
  • integrate page_orientation_predictor

NOTE: Draft until TF orientation models are merged

Any feedback is welcome 🤗

Closes: #1460

Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.29%. Comparing base (9c92f5c) to head (3f93c5e).

Files Patch % Lines
doctr/models/_utils.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
+ Coverage   96.25%   96.29%   +0.04%     
==========================================
  Files         163      163              
  Lines        7707     7729      +22     
==========================================
+ Hits         7418     7443      +25     
+ Misses        289      286       -3     
Flag Coverage Δ
unittests 96.29% <98.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixdittrich92 felixdittrich92 added this to the 0.9.0 milestone May 15, 2024
@felixdittrich92 felixdittrich92 linked an issue May 15, 2024 that may be closed by this pull request
@felixdittrich92 felixdittrich92 self-assigned this May 15, 2024
@felixdittrich92 felixdittrich92 added type: enhancement Improvement module: models Related to doctr.models type: code quality Related to code quality labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: models Related to doctr.models type: code quality Related to code quality type: enhancement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[orientation] Add page orientation interface & integration
1 participant