T 1404636: Fix pipeline issue #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolovev
requested changes
Mar 3, 2025
| @@ -57,10 +57,7 @@ public final class KeychainHybridKeyProvider: HybridKeyProvider { | |||
| guard let errorCode = error.flatMap({ LAError.Code(rawValue: $0.code) }) else { | |||
| return false | |||
| } | |||
| if #available(OSX 10.13, iOS 11, *) { | |||
There was a problem hiding this comment.
Since we declare compatibility with iOS 9 in Package.swift, I don't think we can remove this availability check.
There was a problem hiding this comment.
If you still want to fix the warning, I am not sure that this #availability check is correct. You can try something like if #available(iOS 10, macOS 10.13, *) instead
|
The changes are not required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes (pick all that apply):
Summary
Fix pipeline failing issue by removing outdated checks for Touch ID availability on older versions of macOS and iOS.
Implementation
touchIDNotAvailablefor versions prior to macOS 10.13 and iOS 11.Test Plan