-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T 1404619: Update new network error condition in OAuth2Error #171
Merged
amrutakamat-mindbody
merged 2 commits into
main
from
Task/1404619-Handle-network-error-case-in-OAuth2Error
Mar 3, 2025
Merged
T 1404619: Update new network error condition in OAuth2Error #171
amrutakamat-mindbody
merged 2 commits into
main
from
Task/1404619-Handle-network-error-case-in-OAuth2Error
Mar 3, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment
asolovev
reviewed
Mar 3, 2025
asolovev
approved these changes
Mar 3, 2025
rohitpradhan03
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AnshulMindbody
approved these changes
Mar 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes (pick all that apply):
Summary
Handle network failures by adding a new error case for network failures and updating the error handling logic for
refresh token API
for this new case.Implementation
networkFailure
to theOAuth2Error
enum to represent network failures.errorFrom
method to accept an additionalerror
parameter and returnOAuth2Error.networkFailure
for network-related errors.errorFrom
to pass the newerror
parameter.Test Plan
Refresh Token
API and verify if the error returningOAuth2Error.networkFailure
when received network error (NSURLDomainErrorCode is < 0).