Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T 1164100: Add check for nil request URL #166

Merged
merged 3 commits into from
Oct 22, 2022

Conversation

ruchiupgade-mb
Copy link
Contributor

@ruchiupgade-mb ruchiupgade-mb commented Oct 19, 2022

This pull request includes (pick all that apply):

  • Bugfixes
  • New features
  • Breaking changes
  • Documentation updates
  • Unit tests
  • Other

Summary

In URLSessionClient if the modifiedRequest URL is nil, the data task was not getting initialized. Because of this The callback is not fired.

In this fix we have added a check for nil URL. If the request URL is nil we are initiating a callback with missingURL error.

Implementation

Test Plan

@ruchiupgade-mb ruchiupgade-mb marked this pull request as ready for review October 20, 2022 06:04
Copy link
Contributor

@plflanagan plflanagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one quick change request. Let me know when made and I can quickly re-review.

@ruchiupgade-mb ruchiupgade-mb merged commit 5fa6640 into main Oct 22, 2022
@ruchiupgade-mb ruchiupgade-mb deleted the task/116400-fix-for-fma-loader-issue branch October 22, 2022 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants