-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T 072733: Update multipart form request serializer #165
T 072733: Update multipart form request serializer #165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left one comment, but I will also leave final approval to others who have more experience with conduit and understand the implications better of changing it.
Sources/Conduit/Networking/Serialization/MultipartFormRequestSerializer.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems fine. Added a suggestion about using "Random Unification" methods.
There is also a note in RFC2046
WARNING TO IMPLEMENTORS: The grammar for parameters on the Content-
type field is such that it is often necessary to enclose the boundary
parameter values in quotes on the Content-type line. This is not
always necessary, but never hurts.
It doesn't seem necessary in our case, but if there will be additional problems, we can try it as well or use a longer boundary.
This pull request includes (pick all that apply):
Summary
RestAPI
.RestAPI
endpoint in question (/Documents/LiabilityRelease?consumerId=[ID]
) wasn't accepting the existing boundary value.Implementation
MultipartFormRequestSerializer
.Test Plan
MultipartFormRequestSerializer
.