Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing a custom completion queue to ImageDownloader #162

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

eneko
Copy link
Contributor

@eneko eneko commented Jul 1, 2021

This pull request includes (pick all that apply):

  • Bugfixes
  • New features
  • Breaking changes
  • Documentation updates
  • Unit tests
  • Integration tests
  • Other

Summary

Allow passing a custom operation queue to ImageDownloader to be used when calling the completion callback.

Implementation

  • Add completionQueue parameter to initializer (defaults to nil)
    • If no value is passed, ImageDownloader will behave as before, defaulting to the current operation queue for completion, or main if there is no current queue.
    • When a queue is specified, it will be used instead.

Test Plan

  • Run integration tests

Copy link
Contributor

@plflanagan plflanagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@eneko eneko merged commit fdf1e5c into main Jul 1, 2021
@eneko eneko deleted the task/image-downloader-queue branch July 1, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants