Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local web server & Carthage #159

Merged
merged 6 commits into from
Feb 10, 2021
Merged

Remove local web server & Carthage #159

merged 6 commits into from
Feb 10, 2021

Conversation

eneko
Copy link
Contributor

@eneko eneko commented Jan 26, 2021

This pull request includes (pick all that apply):

  • Bugfixes
  • New features
  • Breaking changes
  • Documentation updates
  • Unit tests
  • Other

Summary

Conduit CI has been broken for a long time (since March 2020):

This is mainly because the local web-server used for unit and integration tests was outdated. As new versions of Ruby and Python have been released, and our systems and CI servers upgraded, the local server stopped running. Quite some good tech-debt we had queued.

Implementation

  • Remove local web servers
    • httpbin has been replaced with calls to https://httpbin.org (as we originally had). Video assets have been reduced in size for faster round-trips during testing.
    • oauth-test-server has been removed and not replaced (a handful of tests have been disabled for now)
  • Project and workspace files have been removed to simplify the codebase and maintenance efforts.
  • Carthage support has also been removed, might be added later as XCFramework if there is public demand.
  • Travis CI has been removed
  • GitHub Actions have been set up for CI

Test Plan

  • Run all tests with swift test or from Xcode

@eneko eneko changed the base branch from main to release/1.0.0 January 26, 2021 18:13
@eneko eneko changed the title M: Remove local web server & Carthage M 934046: Remove local web server & Carthage Jan 28, 2021
@eneko eneko changed the title M 934046: Remove local web server & Carthage Remove local web server & Carthage Feb 4, 2021
Copy link
Contributor

@tiltem tiltem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anyway to not disable those tests?

@eneko
Copy link
Contributor Author

eneko commented Feb 4, 2021

@tiltem this subset of tests have been broken for a long time (since CI stopped running). I've been looking for a replacement for oauth-test-server, but unfortunately haven't found a good solution yet. My intention is to have those tests running later on.

I've added AB#937603 to track this work.

@eneko eneko changed the base branch from release/1.0.0 to main February 10, 2021 05:11
@eneko eneko merged commit ea57578 into main Feb 10, 2021
@eneko eneko deleted the remove/local-webserver branch February 10, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants