Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated types #156

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Remove deprecated types #156

merged 3 commits into from
Oct 8, 2020

Conversation

eneko
Copy link
Contributor

@eneko eneko commented Oct 6, 2020 •
edited
Loading

This pull request includes (pick all that apply):

  • Bugfixes
  • New features
  • Breaking changes
  • Documentation updates
  • Unit tests
  • Other

Summary

  • Remove deprecated types: BearerOAuth2Token, OAuth2TokenAES256CBCCipher, and OAuth2TokenDiskStore
  • Set IPHONEOS_DEPLOYMENT_TARGET to 9.0 for all Conduit targets

@eneko eneko requested a review from johnhammerlund October 6, 2020 18:40
johnhammerlund
johnhammerlund approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@johnhammerlund johnhammerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 good to kill these warnings once and for all

@eneko eneko merged commit 6aa00e3 into master Oct 8, 2020
@eneko eneko deleted the remove/deprecations branch October 8, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnhammerlund johnhammerlund johnhammerlund approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eneko @johnhammerlund