-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Maint)|Export Dynamic library for SwiftPM #148
Conversation
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
- Coverage 79.67% 79.08% -0.60%
==========================================
Files 70 70
Lines 2755 2529 -226
==========================================
- Hits 2195 2000 -195
+ Misses 560 529 -31
Continue to review full report at Codecov.
|
Package.swift
Outdated
.library(name: "ConduitStatic", targets: ["Conduit"]), | ||
.library(name: "Conduit", type: .dynamic, targets: ["Conduit"]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change the current target from static to dynamic, correct? Would it be safer to instead create a ConduitDynamic
target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed to me that for most of our apps we were going to need the dynamic one, so I made that one the "default". But yes, we can do it that way. It would prevent any impact on anyone currently using Conduit
via SwiftPM without this issue.
Will switch them now.
This pull request includes (pick all that apply):
Summary
Applications with extensions (eg. Today Widget) that consume Conduit via SwiftPM will need to import Conduit as a dynamic framework starting in Xcode 11.4.
Implementation
ConduitDynamic
Test Plan