Skip to content

Add a modified random forest estimator #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

lionelkusch
Copy link
Collaborator

Keep a trace of the estimators after deleting it in PR #166

@bthirion bthirion mentioned this pull request Mar 7, 2025
Copy link
Collaborator

@jpaillard jpaillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following up on #166 I suggest including the examples_not_exhibited/plot_residuals_sampling.py, which shows how the modified RF can be used for conditional sampling. Method presented in Chamma_NeurIPS2023

@lionelkusch
Copy link
Collaborator Author

Note: The example examples_not_exhibited/plot_residuals_sampling.py need to be modfied because it use BBI which is not include in the library (see issue #42 )

@bthirion
Copy link
Collaborator

This is a perfect illustration of the fact that examples_not_exhibited is a terrible anti-pattern and should not stay in the mean/long term.

@lionelkusch lionelkusch marked this pull request as draft March 18, 2025 16:56
@lionelkusch lionelkusch added the estimators question link to estimators label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimators question link to estimators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants