ADA-SVR (2/4) Test for models #101
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelkusch
requested review from
bthirion,
Remi-Gau and
jpaillard
and removed request for
jpaillard
This was referenced Dec 26, 2024
Open
fix typo errors Co-authored-by: bthirion <[email protected]>
lionelkusch
force-pushed
the
PR_test_ADA_SVR
branch
from
3a51e49 to
8c953e2
Compare
lionelkusch
changed the title
lionelkusch
force-pushed
the
PR_test_ADA_SVR
branch
from
00dcdae to
8902945
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 923 942 +19
=========================================
+ Hits 923 942 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Since this is about tests, would creating fixtures in the |
bthirion
reviewed
Feb 26, 2025
| estimator.fit(X, y) | ||
| beta_hat_svr = estimator.coef_ | ||
|
|
||
| # compare that the coefficiants are the same that the one of SVR |
There was a problem hiding this comment.
Suggested change
| # compare that the coefficiants are the same that the one of SVR | |
| # check that the coefficients are the same as the ones of SVR |
| assert np.max(np.abs(beta_hat - beta_hat_svr.T[:, 0])) < 2e-4 | ||
|
|
||
| weights, weights_distribution = permutation_test( | ||
| X, y, estimator=estimator, n_permutations=10000, n_jobs=8, seed=42 |
There was a problem hiding this comment.
In a test, you probably want to have a much lower number of permutations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a modification of other PR (#74, #73, #99, #100)
This pull request is about the tests for the ada_svr. I added a functional test to complete the unit of test of the functions.