Use lmdb store for swap requests #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f1f23c4295097e0f806098647dcc2a4d31715355)
(cherry picked from commit 7ab6d3086e4c946ef117ed244bd33c87ff5b9142)
scilio
commented
Sep 14, 2022
| pub enum SwapStatus { | ||
| Unprocessed, | ||
| InProcess { kernel_hash: Hash }, | ||
| Completed { kernel_hash: Hash, block_hash: Hash }, |
There was a problem hiding this comment.
We don't use the Completed status yet, nor do we delete SwapData entries after they've long been confirmed. That will be added as part of #8
phyro
approved these changes
Sep 16, 2022
| #[derive(Clone, Debug, PartialEq)] | ||
| pub enum SwapStatus { | ||
| Unprocessed, | ||
| InProcess { kernel_hash: Hash }, |
There was a problem hiding this comment.
nitpick: At first I wrongly assumed the InProcess was during the round communication when it's really after it's been sent to the mempool and before being sealed on the chain. Might make sense to add a comment explaining these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than use an in-memory cache for swap requests waiting to be processed, we switch to using an lmdb database to avoid data loss in the event of a process interruption.
Fixes #5