Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Select L2 segments in L0Compaction as well #32991

Merged
merged 4 commits into from May 21, 2024

Conversation

bigsheeper
Copy link
Contributor

/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 11, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 11, 2024
Copy link
Contributor

mergify bot commented May 11, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (1ef975d) to head (a5efcef).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32991      +/-   ##
==========================================
+ Coverage   82.14%   82.17%   +0.03%     
==========================================
  Files        1006     1006              
  Lines      128452   128452              
==========================================
+ Hits       105513   105558      +45     
+ Misses      18948    18907      -41     
+ Partials     3991     3987       -4     
Files Coverage Δ
internal/datacoord/compaction.go 88.19% <100.00%> (ø)

... and 31 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented May 12, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 12, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 14, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label May 17, 2024
@czs007
Copy link
Contributor

czs007 commented May 21, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 017fd7b into milvus-io:master May 21, 2024
15 checks passed
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm PR | need cherry-pick need cherry pick to other branches size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants