Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should init access logger before init server #32976

Merged
merged 1 commit into from May 14, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented May 11, 2024

relate: #32968

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 11, 2024
Copy link
Contributor

mergify bot commented May 11, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor

/run-cpu-e2e

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.09%. Comparing base (293f14a) to head (1a07242).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32976      +/-   ##
==========================================
+ Coverage   82.06%   82.09%   +0.03%     
==========================================
  Files        1007     1007              
  Lines      127699   127699              
==========================================
+ Hits       104793   104835      +42     
+ Misses      18931    18900      -31     
+ Partials     3975     3964      -11     
Files Coverage Δ
internal/distributed/proxy/service.go 84.08% <100.00%> (+0.02%) ⬆️
internal/proxy/proxy.go 70.34% <ø> (-2.01%) ⬇️

... and 33 files with indirect coverage changes

Copy link
Contributor

mergify bot commented May 11, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented May 13, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 13, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia, Yherealtita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit dc058ea into milvus-io:master May 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants