[Bug]: partition name breaks the name rule if trying to create a parititon with name="12name"

[yanliang567]

Is there an existing issue for this?

• I have searched the existing issues

Environment

- Milvus version: master-20240508-3d78b90f
- Deployment mode(standalone or cluster): standalone
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2): 2.5.0rc18

Current Behavior

"12name" starts with number, so it is not a valid partition name for milvus, but milvus did not check that.

Expected Behavior

As the doc of https://milvus.io/docs/limitations.md says:

Milvus shall report error if name is invalid

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

[yanliang567]

/assign @congqixia
/unassign

[congqixia]

It's easy to forbid partition name starting with number, but this will cause legacy partitions unable to be operated on after upgraded to this image.
Can we use non-restrict mode verifying partition name other than CreatePartition?

milvus/internal/proxy/util.go

Lines 215 to 246 in f677726

	func validatePartitionTag(partitionTag string, strictCheck bool) error {
	partitionTag = strings.TrimSpace(partitionTag)
	invalidMsg := "Invalid partition name: " + partitionTag + ". "
	if partitionTag == "" {
	msg := invalidMsg + "Partition name should not be empty."
	return errors.New(msg)
	}
	if len(partitionTag) > Params.ProxyCfg.MaxNameLength.GetAsInt() {
	msg := invalidMsg + "The length of a partition name must be less than " + Params.ProxyCfg.MaxNameLength.GetValue() + " characters."
	return errors.New(msg)
	}
	if strictCheck {
	firstChar := partitionTag[0]
	if firstChar != '_' && !isAlpha(firstChar) && !isNumber(firstChar) {
	msg := invalidMsg + "The first character of a partition name must be an underscore or letter."
	return errors.New(msg)
	}
	tagSize := len(partitionTag)
	for i := 1; i < tagSize; i++ {
	c := partitionTag[i]
	if c != '_' && !isAlpha(c) && !isNumber(c) {
	msg := invalidMsg + "Partition name can only contain numbers, letters and underscores."
	return errors.New(msg)
	}
	}
	}
	return nil
	}

@czs007 @xiaofan-luan @yanliang567 WDYGT?

[xiaofan-luan]

keep the old convention？
I don't foresee any reason right now we need to forbid name start with numeric number. but this is not recommneded

[congqixia]

keep the old convention？ I don't foresee any reason right now we need to forbid name start with numeric number. but this is not recommneded

lgtm, +1

[yanliang567]

close as won't for compatible with previous releases.