Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forbid partition name start with number #33008

Closed

Conversation

congqixia
Copy link
Contributor

Related to #32998

Signed-off-by: Congqi Xia [email protected]

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 13, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 13, 2024
@congqixia
Copy link
Contributor Author

/hold

Copy link
Contributor

mergify bot commented May 13, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.08%. Comparing base (230c88b) to head (709affe).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33008      +/-   ##
==========================================
+ Coverage   82.07%   82.08%   +0.01%     
==========================================
  Files        1007     1007              
  Lines      127668   127701      +33     
==========================================
+ Hits       104778   104827      +49     
+ Misses      18915    18903      -12     
+ Partials     3975     3971       -4     
Files Coverage Δ
internal/proxy/util.go 90.94% <100.00%> (+0.20%) ⬆️

... and 40 files with indirect coverage changes

@congqixia congqixia closed this May 13, 2024
@congqixia congqixia deleted the fix/restrict_partition_name branch May 14, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. do-not-merge/hold kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants