Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add client rate limit support #20

Merged
merged 3 commits into from
Mar 22, 2024
Merged

feature: add client rate limit support #20

merged 3 commits into from
Mar 22, 2024

Commits on Mar 22, 2024

  1. feature: add client rate limit support 

    You can specify your own rate limiter to limit the number of requests
sent to the remote API.

The easiest way is probably to use the off the shelf Limiter implemented
by https://pkg.go.dev/golang.org/x/time/rate#Limiter

We had to refactor the API a bit so we can wrap the http client with the
provided limiter and also make room for adding retries.

Signed-off-by: Milos Gajdos <[email protected]>
    @milosgajdos
    milosgajdos committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e77ae2f View commit details
    Browse the repository at this point in the history

  2. update: update godoc for client.Limiter interface 

    Signed-off-by: Milos Gajdos <[email protected]>
    @milosgajdos
    milosgajdos committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    6cce5b7 View commit details
    Browse the repository at this point in the history

  3. fix: only call client.Limiter.(Wait) if limiter was initialized 

    Signed-off-by: Milos Gajdos <[email protected]>
    @milosgajdos
    milosgajdos committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    f373386 View commit details
    Browse the repository at this point in the history