Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimise future fields: use regular reference when possible #418

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DenKoren
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 08f9dc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -842,6 +850,13 @@ field = func(f) {
* @return field: smart.field
*/
getFutureField: func(name, fieldType, ...eph) {
fldInfo := self.info()
if fldInfo.Value != 0 && fldInfo.Error == 0 && fldInfo.Type != constants.FTYPE_OUTPUT {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we need this. This optimisation may 'remove' one element from TIDs chain which will affect deduplication and recovery. But when we skip outputs, it seems like we almost disable the optimisation completely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky thing here is to optionally add a non-ephemeral future-field, based on some state that may change depending on how certain races in the system are resolved. This way we will introduce a different CID (not TID) in the chain, which in tern may spoil de-duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants