Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2024 12 18 #78

Open
wants to merge 193 commits into
base: v4
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
193 commits
Select commit Hold shift + click to select a range
4940d3a
more options in list-files. Return 'paths' instead of 'files'
DenKoren Oct 15, 2024
dbae71f
chore: move list-files action to actions/files/list
DenKoren Oct 15, 2024
4704c5a
provide the ability to glob with relative paths
DenKoren Oct 15, 2024
0e14bf7
make relative paths to always start with './'
DenKoren Oct 15, 2024
00dbcd4
feat: artifact save and restore actions that preserve permissions
DenKoren Oct 15, 2024
7574565
correct name of files/list action after renaming
DenKoren Oct 15, 2024
146f4e8
do not try to use github context variables as input defaults
DenKoren Oct 15, 2024
ecbb547
chore: do not use github context variables in inputs description
DenKoren Oct 15, 2024
de600fb
chore: add debug to artifact/save action
DenKoren Oct 15, 2024
2296ea4
chore: read correct files list
DenKoren Oct 15, 2024
14955d0
chore: save relative paths when creating artifacts tar
DenKoren Oct 15, 2024
a4ee726
move debug to artifact/restore action
DenKoren Oct 15, 2024
dc5197a
chore: drop broken step reference
DenKoren Oct 15, 2024
aed5ed5
change artifact download settings in artifact/restore
DenKoren Oct 15, 2024
4de6381
correct path to artifact archive
DenKoren Oct 15, 2024
46c2ab3
check artifact name is not empty
DenKoren Oct 15, 2024
51c4fac
we now extract single artifact. No prefix needed
DenKoren Oct 15, 2024
7c736b7
fix bash syntax
DenKoren Oct 15, 2024
3d63033
feat: support groups of artifacts in restore
DenKoren Oct 15, 2024
96a80ac
add debug to restore action
DenKoren Oct 15, 2024
21ff054
disable debug again
DenKoren Oct 15, 2024
5c84859
add sanity check to artifact/restore action
DenKoren Oct 15, 2024
b870665
sanity check update
DenKoren Oct 15, 2024
d08b801
attempt to fix hidden subshell issue in sanity check
DenKoren Oct 15, 2024
9467366
fix redirect syntax
DenKoren Oct 15, 2024
47baf54
copy notarize tools to public CI repo
DenKoren Oct 15, 2024
c656615
feat: add node-python-matrix workflow draft
DenKoren Oct 15, 2024
4424b49
bring lost npmrc-config option from v4 to v4-beta
DenKoren Oct 16, 2024
f41ebf9
format yaml (no functional changes)
DenKoren Oct 16, 2024
114c7fd
teach node prepare action to update npm and install dependencies
DenKoren Oct 16, 2024
19efd68
teach npm-pkg-status to load name and version from package.json
DenKoren Oct 16, 2024
8880a8e
chore: use new install-deps and update-npm features of node/prepare
DenKoren Oct 16, 2024
cac8d4c
put package existence check into 'release' job
DenKoren Oct 16, 2024
805e2f2
make matrix os and arch to be optional inputs
DenKoren Oct 16, 2024
198d7b6
attempt to simplify matrix control
DenKoren Oct 16, 2024
6db9c65
fix node-python-matrix definition (syntax, job dependencies)
DenKoren Oct 16, 2024
e567e59
do not try to sign empty list of binaries
DenKoren Oct 16, 2024
5bd6c71
enable interactive debug for windows build to investigate pl-pkg problem
DenKoren Oct 16, 2024
35041ea
do not start notarize if no paths given
DenKoren Oct 16, 2024
a2f39b8
fix runner name for 'release' step
DenKoren Oct 16, 2024
f8240c6
do not patch version in package.json (we use branch-versioning in WF)
DenKoren Oct 16, 2024
fbaa0e3
switch interactive debug to Linux
DenKoren Oct 16, 2024
71bbe09
do not implicit files
DenKoren Oct 16, 2024
010b83a
more options in files/list
DenKoren Oct 16, 2024
67465a6
lists of artifacts in macos-notarize, match only files in macos-sign
DenKoren Oct 16, 2024
a03d9ea
disable interactive debug for linux in node-python-matrix
DenKoren Oct 16, 2024
e0eee51
do not include descendants into matched list (will archive anyway)
DenKoren Oct 16, 2024
053d293
stdout of shell scripts at build and test actions may be HUGE
DenKoren Oct 17, 2024
2af2b52
windows signing settings refactoring
DenKoren Oct 17, 2024
0750c9f
add check for paths list before signing
DenKoren Oct 17, 2024
1321cc4
add id-token permission in build-and-test for GCP auth
DenKoren Oct 17, 2024
25b624b
feat: teach windows-sign to treat lists of files
DenKoren Oct 17, 2024
a1809c3
fix: rename windows-sign input
DenKoren Oct 17, 2024
234fed7
rename input of windows-sign
DenKoren Oct 17, 2024
a8a0fad
enable interactive debug of windows-sign
DenKoren Oct 17, 2024
16bcf9a
disable interactive-debug
DenKoren Oct 17, 2024
0b9f6f9
chore: fix broken secrets access expression
DenKoren Oct 17, 2024
ec0bb3a
treat empty signing list as warning
DenKoren Oct 17, 2024
31be4c6
write 'warning' to stderr in powershell. Reorder steps in windows-sign
DenKoren Oct 17, 2024
268a31d
syntax fix in powershell
DenKoren Oct 17, 2024
08638b6
fix powershell syntax
DenKoren Oct 17, 2024
1d49cd8
add 'hasMatches' output to files/list action
DenKoren Oct 17, 2024
301245e
Use files/list has-matches output in windows-sign
DenKoren Oct 17, 2024
d5b4e6c
add 'is-empty' output to files/list action
DenKoren Oct 17, 2024
be82a29
provide matched files as indented list in logs
DenKoren Oct 17, 2024
a678140
dump list of paths to be archived to CI log
DenKoren Oct 17, 2024
904ef45
Escape paths on windows to make tar work
DenKoren Oct 17, 2024
c45186a
chore: enable interactive debug for artifact/save action on mac os x
DenKoren Oct 17, 2024
22f90a7
Merge branch 'v4-beta' of github.com:milaboratory/github-ci into v4-beta
DenKoren Oct 17, 2024
9131b20
set default reaction on 'nothing found' to error in artifact/save
DenKoren Oct 17, 2024
d4b8376
fix: archive directories contents when creating tar at artifact/save
DenKoren Oct 17, 2024
6963bca
feat: files/list now can write the result to file
DenKoren Oct 17, 2024
3d16231
disable interactive debug
DenKoren Oct 17, 2024
495f965
chore: fix issues in node-go-simple
DenKoren Oct 18, 2024
b4ec918
fix bash syntax in macos-sign
DenKoren Oct 18, 2024
cf55d64
fix: try to use linux delimiters in files list for tar on windows
DenKoren Oct 21, 2024
2bcc64f
attempt to use '${{github.action_ref}}' to avoid conflicts
DenKoren Oct 21, 2024
714f13a
attempt to use github action ref var in composite actions
DenKoren Oct 21, 2024
097c1b6
attempt to use github context var to reference actions version
DenKoren Oct 21, 2024
bea7854
attempt to use local action reference
DenKoren Oct 21, 2024
04edd04
attempt to use local action reference
DenKoren Oct 21, 2024
1026a0a
attempt to use relative action reference
DenKoren Oct 21, 2024
dd5bcbb
no way to use relative paths :(
DenKoren Oct 21, 2024
e802535
restore normal workflow settings
DenKoren Oct 21, 2024
18b7f42
fix: check correct package for existence (configure NPM before checking)
DenKoren Oct 21, 2024
00713ee
fix: allow 'release' action to write tags
DenKoren Oct 21, 2024
41feb86
feat: dump full notarization response when ID is empty
DenKoren Oct 22, 2024
28d8c28
chore: update node-go-simple wf
mike-ainsel Oct 22, 2024
ad0984c
chore: add pnpm merge queue inital wf
mike-ainsel Oct 22, 2024
453de2e
never inline github substitutions into shell script
DenKoren Oct 23, 2024
dc4cd5b
chore: latest changes
mike-ainsel Oct 24, 2024
4e805f2
chore: use pnpm dlx to run cmds
mike-ainsel Oct 24, 2024
9358eb1
chore: change pnpm run cmd
mike-ainsel Oct 24, 2024
12092e6
chore: get list of changed files
mike-ainsel Oct 24, 2024
1c1872a
chore: add zen artisian token generation
mike-ainsel Oct 24, 2024
f669b23
chore: fix zen token gen action
mike-ainsel Oct 24, 2024
398219d
chore: get secrets form envs
mike-ainsel Oct 24, 2024
06bab35
chore: add secrets
mike-ainsel Oct 24, 2024
7be2fb6
chore: add user detection for commits to main
mike-ainsel Oct 24, 2024
618c032
chore: chacked for ignored files
mike-ainsel Oct 24, 2024
218b5c0
chore: show all changed files
mike-ainsel Oct 24, 2024
e79363c
chore; use different action to check chnaged files during wf run
mike-ainsel Oct 28, 2024
5f9959c
chore: verify-changed-files fix variables
mike-ainsel Oct 28, 2024
19806d8
chore: add tests
mike-ainsel Oct 28, 2024
0180011
chore: get user id in common shell
mike-ainsel Oct 28, 2024
ce301d1
chore: clear pl logs restore assets ownership after tests
mike-ainsel Oct 28, 2024
11be8cf
chore: add quotes
mike-ainsel Oct 28, 2024
0500ca0
chore: fix quotes
mike-ainsel Oct 28, 2024
3c0270d
chore: add turborepo cache on s3 bucket
mike-ainsel Oct 28, 2024
012fef3
chore: fix version
mike-ainsel Oct 28, 2024
1422500
chore: update monorepo wf
mike-ainsel Oct 29, 2024
37c6d2b
chore: install all pkgs to warm up the cache
mike-ainsel Oct 29, 2024
b6ef828
chore: fix changesets invocation cmd
mike-ainsel Oct 29, 2024
dc2e26d
chore: fetch all history for changesets
mike-ainsel Oct 29, 2024
e592946
chore: add origin to branch name
mike-ainsel Oct 29, 2024
188ea65
chore: fix whitespace
mike-ainsel Oct 29, 2024
6342de4
chore: adjust comments and notifications in python workflow
DenKoren Nov 1, 2024
14b1ffc
feat: add R workflow draft (copy of python)
DenKoren Nov 1, 2024
e878946
distribute our custom patched dylibbundler until it merged into main
DenKoren Nov 1, 2024
6a4bed5
update dylibbundler (bugfix)
DenKoren Nov 1, 2024
b27f393
add 'R' prepare action
DenKoren Nov 1, 2024
75f8414
do not install R into github if r version is not specified
DenKoren Nov 1, 2024
1ea193d
fix 'if' statements syntax
DenKoren Nov 1, 2024
f299dac
fix if statements syntax
DenKoren Nov 1, 2024
b74e126
use full hash in hardened action ref (short are not supported)
DenKoren Nov 1, 2024
633b985
rename r-matrix to simple 'matrix'. We can do all inside: go, R, python
DenKoren Nov 1, 2024
842a34b
use # instead of // for comment in bash script :D
DenKoren Nov 1, 2024
5eb6662
replace 'return' with 'exit 0' as we are not in a function
DenKoren Nov 1, 2024
41d534e
chore: bump versions on pull_request
mike-ainsel Nov 4, 2024
f3eca7a
chore: remove duplicates
mike-ainsel Nov 4, 2024
ddad39d
chore: need to rest
mike-ainsel Nov 4, 2024
9b0cc24
chore: update monorepo wf
mike-ainsel Nov 4, 2024
4181fbd
fix: patch node-simple so it can work in subdirectory
DenKoren Nov 5, 2024
c1510a2
Merge branch 'v4-beta' of github.com:milaboratory/github-ci into v4-beta
DenKoren Nov 5, 2024
dd47cfa
add 'working directory' support to node/prepare action
DenKoren Nov 5, 2024
fb1143c
add custom wd to node/test block into prepare step
DenKoren Nov 5, 2024
64c7a2a
allow control of the runner label on the caller's side
DenKoren Nov 5, 2024
6b09141
make runs-on input optional: it has default value
DenKoren Nov 5, 2024
d813a39
make build-script-name to be optional
DenKoren Nov 5, 2024
74a4a15
do not default into '/' for execution node path
DenKoren Nov 5, 2024
9bdf6ec
temporary debug of action
DenKoren Nov 5, 2024
30e1d93
drop debug
DenKoren Nov 5, 2024
ec204b5
update dylibbundler util (--skip-missing + --skip-patching)
DenKoren Nov 7, 2024
5ae2b6b
dylibbundler: do not rewrite library names when --skip-patching is set
DenKoren Nov 7, 2024
c52d2d2
update dylibbundler once again
DenKoren Nov 7, 2024
1991413
embed software build and publication into block workflow
DenKoren Nov 8, 2024
6390464
always enable MiLab shell utils in CI
DenKoren Nov 8, 2024
04a3c4a
always bring milabs shell utils
DenKoren Nov 8, 2024
4f9ca9f
try to switch to subdir when publishing
DenKoren Nov 8, 2024
67dfcb2
chore: change how we use agents in node-simple wf
mike-ainsel Nov 10, 2024
d38d23c
update dylibbundler
DenKoren Nov 11, 2024
5f6b4ed
Merge branch 'v4-beta' of github.com:milaboratory/github-ci into v4-beta
DenKoren Nov 11, 2024
8b88d8e
automatically skip files that cannot be signed
DenKoren Nov 12, 2024
75dc509
update dylibbundler once again
DenKoren Nov 12, 2024
4cc88af
customize AWS role assumtion duration
DenKoren Nov 12, 2024
0492e5e
Mac OS X CodeSign improvements (support custom entitlements)
DenKoren Nov 13, 2024
fa7e2f0
do not prepare keychain when ad-hoc codesign is requested
DenKoren Nov 13, 2024
939e8df
fix codesign script
DenKoren Nov 13, 2024
5d77910
fix
DenKoren Nov 13, 2024
65caaea
increase logs verbosity in macos codesign action
DenKoren Nov 13, 2024
5ced143
dump entitlements embedded into code signature
DenKoren Nov 13, 2024
d80c009
disable trap with keychain cleanup when we created nothing
DenKoren Nov 13, 2024
f6db907
display entitlements list by separate command
DenKoren Nov 13, 2024
cc5e3f0
support signature entitlements customisation in node-matrix
DenKoren Nov 13, 2024
796417e
chore: add ability to choose gha runner by label
mike-ainsel Nov 15, 2024
c3f4148
chore: update tj-actions/changed-files
mike-ainsel Nov 15, 2024
2c79ec1
chore: use verify-changed files in monorepo wf
mike-ainsel Nov 18, 2024
48f888a
chore: update changed-files
mike-ainsel Nov 18, 2024
b47ea3a
chore: revert back to verify-changesd files
mike-ainsel Nov 18, 2024
4c9e2f5
chore: set fetch deps to 0
mike-ainsel Nov 18, 2024
b7fcdc2
chore: try new approache
mike-ainsel Nov 19, 2024
a67d74e
chore: check for changes with git diff
mike-ainsel Nov 19, 2024
1c957ce
chore: show uncommited changes
mike-ainsel Nov 19, 2024
f413a1a
chore: check for local files unstaged and staged
mike-ainsel Nov 19, 2024
6bcf580
chore: add diff flags explicitly for git diff
mike-ainsel Nov 19, 2024
69c412a
chore: check with git for tracked files and unstaged deleted files
mike-ainsel Nov 19, 2024
cec02fe
chore: add untacked files checking
mike-ainsel Nov 19, 2024
1a4972f
chore: remove unnneeded parameters
mike-ainsel Nov 19, 2024
f4ef94d
chore: add team id as input
mike-ainsel Nov 25, 2024
4e8903d
chore: install additional software on dev-assets agents
mike-ainsel Dec 3, 2024
a5a38ec
chore: add additional software for dev-assets agents
mike-ainsel Dec 3, 2024
e0829c9
chore: set timeout limit for a job in node-simple wf
mike-ainsel Dec 4, 2024
bf09ee8
chore: add tag on release for monorepo wf, feat: add mark-stable wf f…
mike-ainsel Dec 12, 2024
5605087
chore: add init in makr stable wf
mike-ainsel Dec 12, 2024
1b50d71
chore: add skipIfReleaseExists in monorepo wf for tags
mike-ainsel Dec 12, 2024
6ccaaba
chore: use pnpm version from root package.json
mike-ainsel Dec 13, 2024
3612441
feat: add 'go' support to node-simple-pnpm
DenKoren Dec 17, 2024
98ac113
do not require golang version in node-simple-pnpm. Go is optional
DenKoren Dec 17, 2024
c10e5af
allow to skip pl service start step
DenKoren Dec 18, 2024
787f65c
allow to skip pl service start step (2nd attempt)
DenKoren Dec 18, 2024
373bb05
don't try to chown assets when it was not created at all
DenKoren Dec 18, 2024
f3e95a8
v4-beta -> v4
DenKoren Dec 18, 2024
70f1e84
Merge branch 'v4' into merge-2024-12-18
DenKoren Dec 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add diff flags explicitly for git diff
  • Loading branch information
mike-ainsel committed Nov 19, 2024
commit 6bcf5809962eb170b72138c29eeb1c191ab0880f
4 changes: 2 additions & 2 deletions .github/workflows/node-simple-pnpm.yaml
Original file line number Diff line number Diff line change
@@ -488,9 +488,9 @@ jobs:
shell: bash
run: |
# Check for unstaged changes
UNSTAGED=$(git diff --name-only)
UNSTAGED=$(git diff --diff-filter=ACMUXTR --name-only)
# Check for uncommitted changes in the staging area
STAGED=$(git diff --name-only --cached)
STAGED=$(git diff --diff-filter=ACMUXTR --name-only --cached)

if [ -n "${UNSTAGED}" ] || [ -n "${STAGED}" ]; then
echo "Local changes detected (unstaged or staged but not committed)."