Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(postgres): allow specifying deferred mode on unique constraints #5537

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

B4nan
Copy link
Member

@B4nan B4nan commented May 4, 2024

Allows specifying deferMode on a unique constraint to get around issues with batch updates mainly.

Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (c7972e7) to head (e2992a2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5537   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         261      261           
  Lines       18096    18100    +4     
  Branches     3860     3864    +4     
=======================================
+ Hits        18050    18054    +4     
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DASPRiD
Copy link
Contributor

DASPRiD commented May 30, 2024

Only after working on #5641 I spotted that you worked on this PR. Looking at the source, it seems we have some overlap, though this is specifically handling manually created unique constraints, while my PR handles unique constraints created automatically for 1:1 relations. How should we proceed on this? :)

@B4nan
Copy link
Member Author

B4nan commented May 31, 2024

i can merge yours first and release to stable, since its a fix. i am keeping this one for v6.3, which i'd like to start working on soon (this weekend probably), i also have #5482 which is waiting for the exact same reason, and have some other small things i want in there that will deserve a blog post

@B4nan B4nan force-pushed the deferred-unique-constraints branch from bf73d9b to e2992a2 Compare June 1, 2024 10:46
@B4nan B4nan merged commit 7672b56 into master Jun 1, 2024
11 checks passed
@B4nan B4nan deleted the deferred-unique-constraints branch June 1, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants