Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency collection to match gradle task #1040

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Fix dependency collection to match gradle task #1040

merged 2 commits into from
Nov 29, 2024
+5 −2

Conversation

redwarp
Copy link
Contributor

@redwarp redwarp commented Nov 26, 2024

Fix dependency collection to match closer the list of dependencies generated by ./gradlew dependencies

Closes #1039

@mikepenz
Copy link
Owner

thank you!

@redwarp
Copy link
Contributor Author

redwarp commented Nov 29, 2024

Do you think there is a chance it can make it in 1.3? (asking for a friend 😇 )

@mikepenz mikepenz self-requested a review November 29, 2024 14:43
@mikepenz mikepenz merged commit cf3e4fa into mikepenz:develop Nov 29, 2024
2 checks passed
@mikepenz
Copy link
Owner

Gonna be in 11.3.0-rc02

Thanks again for the contribution @redwarp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikepenz mikepenz Awaiting requested review from mikepenz

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancies between list of dependencies found by AboutLibrary and the dependencies task
2 participants
@redwarp @mikepenz