Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backtracking on form #1173

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Bartheleway
Copy link

Hi,

This is my trial to fix #1127 (and is also part of #1117)

Here are the main changes :

  • Rewrite paper-input with new syntax
  • Rewrite paper-autocomplete with new syntax
  • Rewrite paper-form with new syntax
  • Get rid of parent & child & validation mixin
    • I deleted the files as they are not used anymore but we can keep them for compatibility with old projects
    • Mixins are deprecated so this is quiet a good news => easier to migrate to octane version
  • Custom validation doesn't handle custom attribute
    • I didn't see any usage for this & I changed the test accordingly to show how to replace usage
    • This was simpler to migrate to new syntax (and octane version maybe), we can try to keep it if really needed
  • I fix some tests related
  • I tried to improve the documentation

The tests runs kind of correctly (I didn't care about non related errors).
It seems that backward (3.12) compatibility is an issue, any ideas on how to solve ?

I didn't find how to write a proper test for backtracking error but I confirm this fix the issue on my project and the test I wrote is really similar to my use case.

Feel free to comment & ask for modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaperForm throwing backtracking assertion 3.16 +
1 participant