Skip to content

Conversation

@rnavyaprabha
Copy link
Collaborator

This PR implements basic edit and delete functionality for activities (tickets) in the app. Users can now:
Edit the title, reference link, and time spent on an activity.
Delete an activity with a confirmation prompt.
Key changes:
Added edit and delete buttons to each activity card in the UI.
When editing, the activity form is pre-filled with the selected activity’s details.
Added server methods for updating and deleting activities, with permission checks.
UI updates reactively after editing or deleting an activity.

YouTube video explaining the functionality:
https://youtube.com/shorts/o-y0ju_SBhs?si=ZI1Qz_rUbs6OfOdF

Note:
When user edits the time admin will be notified about the change.
Advanced features like moving a pasted URL to the reference field and auto filling the title while editing will also be implemented in a separate PR.

@tbaugher-mie
Copy link
Contributor

image

Please update the icons. Use something like font awesome or something, for example. https://fontawesome.com/search

@rnavyaprabha rnavyaprabha self-assigned this Jul 24, 2025
@rnavyaprabha
Copy link
Collaborator Author

@tbaugher-mie @trip-flip Did the code changes, can you please review it now?

Copy link
Contributor

@tbaugher-mie tbaugher-mie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://youtube.com/shorts/_HqHBYELwx4

@rnavyaprabha Deleting tickets will delete them from the session. Tickets should not be removed from running or completed sessions; that is a deletion of history. For running sessions, deleted tickets should appear as if they are inactive, and with their time before deletion still visible. For completed sessions, they should just not be removed at all.

@tbaugher-mie
Copy link
Contributor

image

Another thing, this seems like a conflict of features for the PR. We already have a PR for this, as you know. #31 This shouldn't be present here.

@rnavyaprabha rnavyaprabha marked this pull request as draft August 4, 2025 20:13
@tbaugher-mie tbaugher-mie moved this from Todo to In Progress in TimeHarbor Aug 7, 2025
@tbaugher-mie tbaugher-mie moved this from In Progress to Todo in TimeHarbor Aug 7, 2025
@tbaugher-mie tbaugher-mie linked an issue Aug 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Enable Editing/Deleting Activities

2 participants