Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty list fields from the manifest #563

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Nov 30, 2024

This PR makes it so that empty list fields like Tags: [], Agreements: [] are removed from the manifest before it's serialized.

Validation

Updated unit tests to cover empty lists. For a manual example try:

wingetcreate update VeyonSolutions.Veyon --urls https://github.com/veyon/veyon/releases/download/v4.9.1/veyon-4.9.1.0-win32-setup.exe https://github.com/veyon/veyon/releases/download/v4.9.1/veyon-4.9.1.0-win64-setup.exe --version 2.0.0

and see that Tags: [] is not present in the manifest with this change


Microsoft Reviewers: Open in CodeFlow

@mdanish-kh mdanish-kh requested a review from a team as a code owner November 30, 2024 09:57
@mdanish-kh mdanish-kh requested review from yao-msft and ryfu-msft and removed request for a team November 30, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant