Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JSON Parsing to Use Boost.JSON #198

Open
wants to merge 42 commits into
base: version2.2.0rc
Choose a base branch
from

Conversation

CharityKathure
Copy link
Contributor

This pull request introduces significant changes to the LogMonitor project, primarily focusing on replacing the ConfigFileParser and JsonFileParser with a new JsonProcessor module. This includes the addition of new functions for handling different log types and updating the project files accordingly.

New JsonProcessor module:

  • Added JsonProcessor.cpp with functions to load, parse, and process JSON configuration files, handling different log types such as EventLog, File, ETW, and Process logs.
  • Added JsonProcessor.h with declarations for the new functions in JsonProcessor.cpp.

Project file updates:

  • Updated LogMonitor.vcxproj to include JsonProcessor.cpp and JsonProcessor.h, and removed references to ConfigFileParser.cpp and JsonFileParser.cpp. [1] [2]
  • Updated LogMonitorTests.vcxproj to include JsonProcessorTests.cpp and removed references to ConfigFileParserTests.cpp. [1] [2]

Test updates:

  • Added a new test class JsonProcessorTests in JsonProcessorTests.cpp to test the new JsonProcessor functionalities.
  • Updated LogMonitorTests.cpp to remove the inclusion of ConfigFileParser.cpp.

Codebase simplification:

  • Modified Main.cpp to use loadAndProcessJson instead of OpenConfigFile for reading the configuration file.

These changes aim to enhance the functionality and maintainability of the LogMonitor project by introducing a more robust JSON processing module.

Signed-off-by: Charity Kathure <[email protected]>
@CharityKathure CharityKathure marked this pull request as ready for review November 7, 2024 23:56
CharityKathure and others added 26 commits November 8, 2024 03:18
Signed-off-by: Charity Kathure <[email protected]>
Signed-off-by: Charity Kathure <[email protected]>
Signed-off-by: Charity Kathure <[email protected]>
Signed-off-by: Charity Kathure <[email protected]>
Signed-off-by: Charity Kathure <[email protected]>
Signed-off-by: Charity Kathure <[email protected]>
Signed-off-by: Charity Kathure <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant