Dispose IDisosables in HtmlTransformer #5099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's two IDisposables being used in HtmlTransformer. We should Dispose() both of them.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nohwnd
approved these changes
Jul 8, 2024
|
Can I find this extension on nuget? I can see Microsoft.TestPlatform.Extensions.TrxLogger, but I heed the HtmlLogger so I can override functionality to attachments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's two IDisposables being used in HtmlTransformer (a
Streamand anXmlReader). We should Dispose() both of them.I think this is mostly a hygiene issue. Assembly.GetManifestResourceStream() allocates memory only, not an some non-memory resource that has to be Dispose()d correctly. Same thing for XmlReader too. So I don't think not disposing these has any real impact.
This was flagged by a static analysis too.
Related issue
Kindly link any related issues. E.g. Fixes #xyz. -- Shall I file one?