Skip to content

Insert app.config into VS RocksteadyCLI and switch insertion to main#15736

Merged
nohwnd merged 5 commits intomicrosoft:mainfrom
nohwnd:insert-into-rocksteady
May 5, 2026
Merged

Insert app.config into VS RocksteadyCLI and switch insertion to main#15736
nohwnd merged 5 commits intomicrosoft:mainfrom
nohwnd:insert-into-rocksteady

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented May 5, 2026

Switch insertion from rel/18.7 to main and push src/vstest.console/app.config into VS at src/vset/Agile/TestPlatform/RocksteadyCLI/App.config on every insertion PR.

roslyn-tools --insert-devdiv-source-files is dead code so we push the file ourselves via AzDO API after the PR is created.

- Change insertion source branch from rel/18.7 to main (parameter default + schedule trigger)
- After roslyn-tools creates the insertion PR, push src/vstest.console/app.config to the PR branch at src/vset/Agile/TestPlatform/RocksteadyCLI/App.config in the VS repo
- Parse PR ID from roslyn-tools output to target the correct branch
- Auto-detect whether the file needs 'add' or 'edit' changeType
- Gracefully skip if PR ID can't be extracted (e.g. no-change insertion)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 09:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the VS insertion pipeline to target the main branch by default and extends the insertion automation to copy src/vstest.console/app.config into the VS repo at src/vset/Agile/TestPlatform/RocksteadyCLI/App.config after an insertion PR is created.

Changes:

  • Switch insertion defaults and scheduled insertion branch from rel/18.7 to main.
  • Capture roslyn-tools output to extract the created insertion PR ID.
  • Add an Azure DevOps REST push that updates RocksteadyCLI/App.config on the insertion PR’s source branch (skipping when no PR ID is found).

Comment thread azure-pipelines-insertion.yml
Comment thread azure-pipelines-insertion.yml
nohwnd and others added 2 commits May 5, 2026 12:09
- Reorder regex: match /pullrequest/(\d+) URL first to avoid
  grabbing timestamps from PR titles
- Remove the fallback 'Pull Request #N' pattern that was matching
  build numbers like 20260505100709
- Error out (exit 1) instead of warning when app.config push fails
- Add rocket emoji to step display names
- Set DOTNET_NOLOGO and DOTNET_SKIP_FIRST_TIME_EXPERIENCE

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
HEAD is not supported by AzDO items API, causing the check to
always throw and default to 'add'. Switch to GET with $format=json
and flip the logic: default to 'add', set 'edit' on success.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 10:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Comment thread azure-pipelines-insertion.yml
Comment thread azure-pipelines-insertion.yml
Comment thread azure-pipelines-insertion.yml
Comment thread azure-pipelines-insertion.yml
The file always exists in VS repo — we're overwriting it.
The existence check was causing false negatives and using 'add'
incorrectly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread azure-pipelines-insertion.yml Outdated
Copilot AI review requested due to automatic review settings May 5, 2026 11:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

Comment thread azure-pipelines-insertion.yml
Comment thread azure-pipelines-insertion.yml
Comment thread azure-pipelines-insertion.yml
Comment thread azure-pipelines-insertion.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants