Polish ILanguageModelToolsService #278946
Open
+295
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aeschli
commented
Nov 22, 2025
aeschli
commented
- add an observable for tools and toolsWithFullReferenceName to avoid recomputation
- rename qualifiedName to fullReferenceName
- make things readonly
Contributor
There was a problem hiding this comment.
Pull request overview
This PR polishes the ILanguageModelToolsService interface and implementation with three main improvements: (1) adding observable properties for tools and toolsWithFullReferenceName to avoid recomputation, (2) renaming "qualifiedName" terminology to "fullReferenceName" for better clarity, and (3) making IToolData properties readonly for immutability.
Key Changes
- Added
toolsObservableandtoolsWithFullReferenceNameobservables with proper equality checking to optimize reactive recomputations - Renamed all methods and variables from "qualifiedName" to "fullReferenceName" throughout the codebase for consistency
- Made all IToolData interface properties readonly to ensure immutability after creation
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/languageModelToolsService.ts | Updated IToolData interface with readonly modifiers; renamed interface methods from qualifiedName to fullReferenceName |
| src/vs/workbench/contrib/chat/browser/languageModelToolsService.ts | Added toolsObservable and toolsWithFullReferenceName observables; made private fields readonly; updated all method implementations with new naming |
| src/vs/workbench/contrib/chat/test/browser/languageModelToolsService.test.ts | Updated all test names and assertions to use fullReferenceName terminology |
| src/vs/workbench/contrib/chat/test/common/mockLanguageModelToolsService.ts | Updated mock service to match interface changes with toolsObservable property |
| src/vs/workbench/contrib/chat/test/common/mockLanguageModelToolsConfirmationService.ts | Updated method signature to use readonly modifier |
| src/vs/workbench/contrib/chat/browser/languageModelToolsConfirmationService.ts | Updated method signature to use readonly modifier |
| src/vs/workbench/contrib/chat/common/languageModelToolsConfirmationService.ts | Updated interface method signature to use readonly modifier |
| src/vs/workbench/contrib/chat/common/tools/runSubagentTool.ts | Refactored to build inputSchema before creating IToolData object (required for readonly properties) |
| src/vs/workbench/contrib/chat/browser/chatSelectedTools.ts | Removed local _allTools observable in favor of service's toolsObservable; removed unused observableFromEvent import |
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/*.ts | Updated all prompt syntax language providers to use new fullReferenceName methods |
| src/vs/workbench/api/common/extHost.protocol.ts | Updated IToolDataDto to use readonly modifiers for array properties |
bpasero
approved these changes
Nov 22, 2025
Member
|
Red CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.