Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert addition of Configure option in Open Editors view #241069

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

benibenj
Copy link
Contributor

Remove the recently added Configure option from the overflow menu of the Open Editors view.

closes #240073

@benibenj benibenj self-assigned this Feb 18, 2025
@benibenj benibenj enabled auto-merge (squash) February 18, 2025 10:21
@vs-code-engineering vs-code-engineering bot added this to the February 2025 milestone Feb 18, 2025
@benibenj benibenj disabled auto-merge February 18, 2025 10:24
@benibenj
Copy link
Contributor Author

benibenj commented Feb 18, 2025

Disabled auto merge. Will merge when decision is made

@joaomoreno joaomoreno marked this pull request as draft February 18, 2025 10:57
@joaomoreno
Copy link
Member

@benibenj Converted to draft, so people don't accidentally merge it.

@gjsjohnmurray
Copy link
Contributor

I really hope this doesn't get merged. See #240073 (comment) for some of my reasons.

So far I have only seen half a dozen people saying they're unhappy with the change.

@bpasero
Copy link
Member

bpasero commented Feb 18, 2025

I think this makes sense, so 👍 from my end.

@gjsjohnmurray
Copy link
Contributor

I have created PR #241268 to let users hide the 'More Actions...' button in places where they don't want it.

@benibenj benibenj marked this pull request as ready for review February 24, 2025 14:32
@benibenj benibenj merged commit 3d148bd into main Feb 24, 2025
8 checks passed
@benibenj benibenj deleted the benibenj/poised-takin branch February 24, 2025 14:32
@benibenj
Copy link
Contributor Author

We decided to revert the change as it breaks muscle memory and causes inconsistency. We are open to consider a different approach where right clicking the view title would show configurable settings for the related view

@gjsjohnmurray
Copy link
Contributor

We decided to revert the change as it breaks muscle memory

I hope this reasoning doesn't become a global blocker for ever adding a "More Actions..." button to views that didn't get given one when they first appeared.

I hope that my PR #241268 will get adopted as a way of addressing that objection.

@benibenj
Copy link
Contributor Author

It's always considered a concern, but most of the time it's not a blocker. If an action provides enough value, we are fine with adding it. In this this case, we would have added the configure action to all views which have settings (for consistency), leading to many views suddenly having an overflow action.

Also, we do think that having a context menu action on the view would be a better approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "More Actions..." ellipsis button from Open Editors in explorer
4 participants