-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert addition of Configure option in Open Editors view #241069
Conversation
Disabled auto merge. Will merge when decision is made |
@benibenj Converted to draft, so people don't accidentally merge it. |
I really hope this doesn't get merged. See #240073 (comment) for some of my reasons. So far I have only seen half a dozen people saying they're unhappy with the change. |
I think this makes sense, so 👍 from my end. |
I have created PR #241268 to let users hide the 'More Actions...' button in places where they don't want it. |
We decided to revert the change as it breaks muscle memory and causes inconsistency. We are open to consider a different approach where right clicking the view title would show configurable settings for the related view |
I hope this reasoning doesn't become a global blocker for ever adding a "More Actions..." button to views that didn't get given one when they first appeared. I hope that my PR #241268 will get adopted as a way of addressing that objection. |
It's always considered a concern, but most of the time it's not a blocker. If an action provides enough value, we are fine with adding it. In this this case, we would have added the configure action to all views which have settings (for consistency), leading to many views suddenly having an overflow action. Also, we do think that having a context menu action on the view would be a better approach. |
Remove the recently added Configure option from the overflow menu of the Open Editors view.
closes #240073