Implementation of improvements: Security HardeningandEnhanced Randomness #240662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The cryptography implemented in the original code was not fully secure, so I implemented a replacement of rand::thread_rng() with rand::rngs::OsRng, which provides a higher quality and cryptographically secure source of entropy. - I also implemented the constant_time_eq crate and used its constant_time_eq, this helps prevent attempts to reverse engineer a valid signature by timing how long the comparison takes.
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cryptography implemented in the original code was not fully secure, so I implemented a replacement of rand::thread_rng() with rand::rngs::OsRng, which provides a higher quality and cryptographically secure source of entropy.
I also implemented the constant_time_eq crate and used its constant_time_eq, this helps prevent attempts to reverse engineer a valid signature by timing how long the comparison takes.