Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert windows style path to unix style path #233478

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohankumarelec
Copy link
Contributor

Since the string comparison of file path is done in gulp task, the comparison is always returning false in windows, since the comparison is done with a hardcoded unix style path.

Closes #233477

@bpasero
Copy link
Member

bpasero commented Nov 10, 2024

I would suggest a similar fix as done in https://github.com/microsoft/vscode/pull/233285/files where the entry point gets converted to slashes before calling.

@bpasero bpasero assigned bpasero and unassigned justschen Nov 10, 2024
@wszgrcy
Copy link

wszgrcy commented Nov 18, 2024

After modification, the startup was indeed successful
But why is there a problem with the official build and a problem with the personal build?
Is it due to the official use of customized electrons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code window shows blank screen after building from source
4 participants