chore: update to electron 28 #203956
Merged
chore: update to electron 28 #203956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashworks
reviewed
Feb 1, 2024
deepak1556
force-pushed
the
electron-28.x.y
branch
6 times, most recently
from
ce92c61 to
f94e460
Compare
deepak1556
force-pushed
the
electron-28.x.y
branch
2 times, most recently
from
8ac2ec5 to
e4941c1
Compare
deepak1556
force-pushed
the
electron-28.x.y
branch
3 times, most recently
from
d4ad1ff to
4fff462
Compare
deepak1556
force-pushed
the
electron-28.x.y
branch
3 times, most recently
from
9e5899e to
d674298
Compare
18.18.2 has npm version that has removed the node-gyp script which will cause native modules fail to build that rely on something like `install: node-gyp rebuild` Refs npm/cli@c93edb5
deepak1556
force-pushed
the
electron-28.x.y
branch
from
d674298 to
e69fddf
Compare
bpasero
previously approved these changes
Feb 26, 2024
bpasero
approved these changes
Feb 26, 2024
|
Has anyone actually tested if you can write a vscode extension in ES6 natively and have it load in vscode? Just curious, since that's one of the major standouts of this release. |
|
Indeed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201935
Fixes #203845