Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
sandy081 authored Jul 12, 2023
1 parent 36bfa70 commit 74f6148
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -436,8 +436,8 @@ export abstract class AbstractExtensionManagementService extends Disposable impl
try {
compatible = await this.checkAndGetCompatibleVersion(galleryExtension, false, installPreRelease);

This comment has been minimized.

Copy link
@Lianshup

Lianshup Jul 19, 2023

						if (!isDependency) {
} catch (error) {
if (error instanceof ExtensionManagementError && error.code === ExtensionManagementErrorCode.IncompatibleTargetPlatform && !isDependency) {

This comment has been minimized.

Copy link
@Lianshup
this.logService.info('Skipping the packed extension as it cannot be installed', galleryExtension.identifier.id);

This comment has been minimized.

Copy link
@Lianshup

Lianshup Jul 19, 2023

							this.logService.info('Skipping the packed extension as it cannot be installed', galleryExtension.identifier.id, getErrorMessage(error));

This comment has been minimized.

Copy link
@Lianshup

Lianshup Jul 19, 2023

							this.logService.info('Skipping the packed extension as it cannot be installed', galleryExtension.identifier.id, getErrorMessage(error));
if (!isDependency) {
this.logService.info('Skipping the packed extension as it cannot be installed', galleryExtension.identifier.id, getErrorMessage(error));
continue;
} else {
throw error;
Expand Down

0 comments on commit 74f6148

Please sign in to comment.