Skip to content

Commit

Permalink
fix nb codeactions running on autosave when set true [release] (#19…
Browse files Browse the repository at this point in the history
…4500)

fix nb codeactions running on autosave when set `true`
  • Loading branch information
Yoyokrazy authored Sep 29, 2023
1 parent ccc9961 commit 4268e46
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,8 @@ class CodeActionOnSaveParticipant implements IStoredFileWorkingCopySaveParticipa
if (context.reason === SaveReason.AUTO) {
// currently this won't happen, as vs/editor/contrib/codeAction/browser/codeAction.ts L#104 filters out codeactions on autosave. Just future-proofing
// ? notebook CodeActions on autosave seems dangerous (perf-wise)
saveTrigger = 'always';
// saveTrigger = 'always'; // TODO@Yoyokrazy, support during debt
return undefined;
} else if (context.reason === SaveReason.EXPLICIT) {
saveTrigger = 'explicit';
} else {
Expand Down

0 comments on commit 4268e46

Please sign in to comment.