Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use substituted config instead of raw #2485

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shanto
Copy link

@shanto shanto commented Oct 10, 2024

See this link for details. https://code.visualstudio.com/api/references/vscode-api#DebugConfigurationProvider → resolveDebugConfigurationWithSubstitutedVariables

This commit fixes the issue that variables in debug configs are not resolved, and instead passed as-is to msedge.exe. Using the proper VS Code API easily solves it.

Before

master

After

fix-subst

See this link for details. https://code.visualstudio.com/api/references/vscode-api#DebugConfigurationProvider → resolveDebugConfigurationWithSubstitutedVariables

This commit fixes the issue that variables in debug configs are not resolved. Using the proper VS Code API easily solves it.
@shanto
Copy link
Author

shanto commented Oct 10, 2024

How to test?

Create a debug config as below and try to launch it.

{
			"name": "EdgeBrowserInternal",
			"userDataDir": "${workspaceFolder}/.vscode/edge",
			"type": "vscode-edge-devtools.debug",
			"request": "launch",
}

Without the fix, msedge.exe will complain about non-existing user profile directory. With the fix, Microsoft Edge will launch with the customized user data directory as expected.

@shanto
Copy link
Author

shanto commented Oct 21, 2024

@vidorteg please respond

Copy link

@02clr 02clr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uu

@salvatores-art
Copy link

Contact Us

Name: Email: Phone Number: Message: <textarea required></textarea> Contact Us

@vidorteg
Copy link
Contributor

vidorteg commented Nov 8, 2024

Hi @shanto,

Thank you for the contribution, I'll take a look and reply back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants