Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct usage of toolset and architecture when no configurepreset.generator is defined in the preset. #4208

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Correct usage of toolset and architecture when no configurepreset.generator is defined in the preset. #4208

wants to merge 4 commits into from

Conversation

gcampbell-msft
Copy link
Collaborator

In CMake Presets versions greater than v3, the generator field is optional. Therefore, we needed to improve our logic to handle this case for the toolset and architecture fields.

Fixes #4181

paulmaybee
paulmaybee previously approved these changes Dec 9, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmaybee paulmaybee paulmaybee left review comments

@jophippe jophippe Awaiting requested review from jophippe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake Presets - Architecture field ignored during configuration
2 participants
@gcampbell-msft @paulmaybee