[qtbase] set CMAKE_OSX_DEPLOYMENT_TARGET #43607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 3, 2025
BillyONeal
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Confirming that this works by looking at build results in #43509 . (To be clear, this PR should merge first. But the build results that matter are in that one)
BillyONeal
added
the
depends:different-pr
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 5, 2025
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 5, 2025
|
qtmultimedia broke for the same reason so I gave 2bfaa8e a shot |
FrankXie05
approved these changes
Feb 5, 2025
FrankXie05
added
info:reviewed
|
2bfaa8e passed arm64 testing and is already included in that PR, so I'm going to close that one but mark you as a co-author of the other one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to mitigate https://codereview.qt-project.org/c/qt/qtbase/+/606910
I confirmed that this issue occurs on macOS 15 and can be mitigated by setting VCPKG_OSX_DEPLOYMENT_TARGET. I also verified that downstream ports remain functional by successfully building libqglviewer.