Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EIPScanner] add new port #43569

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

EfesX
Copy link
Contributor

@EfesX EfesX commented Jan 31, 2025

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

Fixes #43547

@EfesX EfesX marked this pull request as draft January 31, 2025 20:01
ports/eipscanner/portfile.cmake Outdated Show resolved Hide resolved
ports/eipscanner/portfile.cmake Outdated Show resolved Hide resolved
ports/eipscanner/usage Outdated Show resolved Hide resolved
ports/eipscanner/usage Outdated Show resolved Hide resolved
ports/eipscanner/package_config.patch Outdated Show resolved Hide resolved
ports/eipscanner/package_config.patch Outdated Show resolved Hide resolved
ports/eipscanner/targets.patch Outdated Show resolved Hide resolved
@EfesX EfesX marked this pull request as ready for review February 2, 2025 08:21
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 5, 2025
@JonLiu1993
Copy link
Member

@EfesX, Thanks for your PR, when I tested the uage by EIPScanner:x64-linux I get this error:

/home/test/Jon/main.cpp:1:10: fatal error: EIPScanner/BaseObject.h: No such file or directory
    1 | #include <EIPScanner/BaseObject.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/test.dir/build.make:76: CMakeFiles/test.dir/main.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/test.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2

"target_include_directories" may be needed.

@JonLiu1993
Copy link
Member

CMakeLists.txt:

cmake_minimum_required(VERSION 3.0)
project(test)
find_package(EIPScanner CONFIG REQUIRED)
add_executable(test main.cpp)
target_link_libraries(test PRIVATE unofficial::eipscanner::eipscanner)

main.cpp:

#include <EIPScanner/BaseObject.h>
#include <stdio.h>
int main()
{
    printf("%s\n", "HELLO WORLD");
    return 0;
}

@EfesX EfesX marked this pull request as draft February 5, 2025 18:46
@EfesX
Copy link
Contributor Author

EfesX commented Feb 5, 2025

@EfesX, Thanks for your PR, when I tested the uage by EIPScanner:x64-linux I get this error:

/home/test/Jon/main.cpp:1:10: fatal error: EIPScanner/BaseObject.h: No such file or directory
    1 | #include <EIPScanner/BaseObject.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/test.dir/build.make:76: CMakeFiles/test.dir/main.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/test.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2

"target_include_directories" may be needed.

@JonLiu1993 I fixed it.

#include <BaseObject.h> should work now.

...for restart CI builds
@JonLiu1993
Copy link
Member

Tested usage successfully by EIPScanner:x64-linux.

@EfesX EfesX marked this pull request as ready for review February 7, 2025 19:40
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] EIPScanner
3 participants